Remove unneeded check on ActiveModel#attribute_aliases - #772
Merged
Conversation
wwahammy
marked this pull request as ready for review
March 29, 2026 19:15
wwahammy
changed the title
ActiveModel#attribute_aliases
sunny
approved these changes
Mar 29, 2026
Member
|
thanks! |
yukideluxe
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
ActiveModel#attribute_aliaseshas been in Rails since at least version 6 so there shouldn't be a reason to check whether the method is on the record class. The removed comment implies it was added in Rails 4 but who knows? In regards to the current supported versions: here's the file included in on Rails 7 and here's the file for Rails 8.This removes the unnecessary check.