Skip to content

Add spec for OptionsExtractor - #776

Merged
sunny merged 3 commits into
RubyMoney:mainfrom
bhawsartanmay:add-options-extractor-spec
May 27, 2026
Merged

Add spec for OptionsExtractor#776
sunny merged 3 commits into
RubyMoney:mainfrom
bhawsartanmay:add-options-extractor-spec

Conversation

@bhawsartanmay

Copy link
Copy Markdown
Contributor

OptionsExtractor had no direct test coverage despite being the shared
utility called by all PostgreSQL migration extension paths
(schema_statements_pg.rb, table_pg.rb).

Adds 13 examples covering:

  • Default :amount and :currency extraction
  • Custom prefix/postfix column name building
  • Explicit column_name override
  • present: false
  • Extra column options (type, precision, scale)
  • String vs symbol table names

@bhawsartanmay
bhawsartanmay force-pushed the add-options-extractor-spec branch from d0f2edb to b403a6d Compare May 1, 2026 09:41

@sunny sunny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@bhawsartanmay

Copy link
Copy Markdown
Contributor Author

👏🏻

Hi @sunny , thank you for approving my PR.

It looks like the CI failure is related to a JRuby compatibility issue between Rails 7.1 / ActiveRecord 7.1 and the JDBC adapter stack. The Rails 7.0 suite passes successfully, but Rails 7.1 fails with:

Java::JavaLang::NoSuchMethodError:
'void org.jruby.RubyHash.<init>(org.jruby.Ruby, int)'

The error originates from arjdbc.jdbc.RubyJdbcConnection, so it seems related to the ARJDBC adapter compatibility with the current JRuby version.

@sunny
sunny merged commit d049f90 into RubyMoney:main May 27, 2026
8 checks passed
@sunny

sunny commented May 27, 2026

Copy link
Copy Markdown
Member

Thanks @bhawsartanmay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants