Add spec for OptionsExtractor - #776
Merged
Merged
Conversation
bhawsartanmay
force-pushed
the
add-options-extractor-spec
branch
from
May 1, 2026 09:41
d0f2edb to
b403a6d
Compare
Contributor
Author
Hi @sunny , thank you for approving my PR. It looks like the CI failure is related to a JRuby compatibility issue between Rails 7.1 / ActiveRecord 7.1 and the JDBC adapter stack. The Rails 7.0 suite passes successfully, but Rails 7.1 fails with: Java::JavaLang::NoSuchMethodError:
'void org.jruby.RubyHash.<init>(org.jruby.Ruby, int)'The error originates from |
Member
|
Thanks @bhawsartanmay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptionsExtractorhad no direct test coverage despite being the sharedutility called by all PostgreSQL migration extension paths
(
schema_statements_pg.rb,table_pg.rb).Adds 13 examples covering:
:amountand:currencyextractioncolumn_nameoverridepresent: falsetype,precision,scale)