Fix/ci lint and jruby - #785
Merged
Merged
Conversation
RuboCop's RSpec/MatchWithSimpleRegex (rubocop-rspec >= 3.10) flags
match(/literal/) on error-message assertions. Autocorrect to
include("literal"); the escaped \$ is preserved as a literal $, so the
assertions are unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rdoc >= 8 introduced a runtime dependency on rbs, whose C extension
fails to build on JRuby ("The compiler failed to generate an executable
file" at the -std=gnu99 check), breaking bundle install before any test
runs. rdoc < 8 has no rbs dependency and still satisfies irb's rdoc
>= 4.0.0 requirement, so pin it below 8 on JRuby only; MRI keeps the
latest rdoc. Verified java-platform resolution now selects rdoc 7.1.0
with rbs absent from the tree.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Gemfile.lock is gitignored, so CI resolves the linters fresh on every run. A new rubocop-rspec minor added RSpec/MatchWithSimpleRegex, which failed lint with no code change (NewCops: enable turns pending cops on). Pin each rubocop gem with ~> x.y.0 to lock the minor (where new cops land) while still allowing patch-level fixes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sunny
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
@sunny this PR fixes CI 😳
First a fix to pin rubocop gems to prevent failures when gems are updated. Pretty similar to RubyMoney/money#1215
Second, rdoc 8 added a hard dependency on rbs >= 4, and rbs 4.x dropped its -java gem so on JRuby it has to compile a C extension, which fails and breaks bundle install before any test runs. rdoc 7.x has no rbs dependency, so pinning it below 8 on JRuby keeps rbs out of the tree entirely. I think we can remove the pin when https://rubygems.org/gems/rbs/versions/4.1.0.pre.2-java is out of prerelease 🤷🏻♀️