Skip to content

aes: refactor backends - #575

Merged
newpavlov merged 3 commits into
masterfrom
aes/ni_inline
Jul 24, 2026
Merged

aes: refactor backends#575
newpavlov merged 3 commits into
masterfrom
aes/ni_inline

Conversation

@newpavlov

@newpavlov newpavlov commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Simplifies and consolidates switching between backends. Fixes performance regression introduced in v0.9.

Closes #574

@newpavlov
newpavlov marked this pull request as ready for review July 21, 2026 14:07
@newpavlov
newpavlov requested a review from tarcieri July 21, 2026 14:07
tarcieri
tarcieri reviewed Jul 23, 2026
View reviewed changes
Comment thread aes/src/lib.rs Outdated
tarcieri
tarcieri reviewed Jul 23, 2026
View reviewed changes
Comment thread aes/src/backends.rs Outdated
tarcieri
tarcieri approved these changes Jul 23, 2026
View reviewed changes

@tarcieri tarcieri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice cleanup that eliminates a lot of duplication.

My personal preference would be to land #560 first, especially as it was opened first. The two PRs together would eliminate quite a bit of duplication.

@newpavlov newpavlov mentioned this pull request Jul 24, 2026
Merged
@newpavlov
newpavlov force-pushed the aes/ni_inline branch 2 times, most recently from f41f496 to 1570839 Compare July 24, 2026 14:51
@newpavlov
newpavlov merged commit e50a0c1 into master Jul 24, 2026
171 checks passed
@newpavlov
newpavlov deleted the aes/ni_inline branch July 24, 2026 15:32
@newpavlov newpavlov mentioned this pull request Jul 24, 2026
Merged
newpavlov added a commit that referenced this pull request Jul 27, 2026
@newpavlov
Release aes v0.9.2 (#577)
18108ae 
### Added
- `hardware_accelerated` function ([#579])

### Changed
- Internal implementation of backends ([#560], [#575])

### Fixed
- Performance regression on x86 targets ([#575])

[#560]: #560
[#575]: #575
[#579]: #579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aes: Performance regressions from aes-0.8.x to 0.9.1 presumably due to differences in inlining on x86_64

2 participants

@newpavlov @tarcieri