der: impl DecodeValue/EncodeValue/Tagged for Cow
#2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Nov 7, 2025
tarcieri
force-pushed
the
der/cow-trait-impls
branch
from
eddff1f to
c4a09a3
Compare
Also includes a POC that the traits work with `OctetStringRef`
tarcieri
force-pushed
the
der/cow-trait-impls
branch
from
c4a09a3 to
aae1db2
Compare
dishmaker
reviewed
Nov 7, 2025
| #[cfg(feature = "alloc")] | ||
| #[test] | ||
| fn cow_octet_string_decode_and_encode() { | ||
| // PrintableString "hi" |
Contributor
There was a problem hiding this comment.
It's not a PrintableString "hi"
dishmaker
reviewed
Nov 7, 2025
| let decoded = Cow::<OctetStringRef>::from_der(EXAMPLE).unwrap(); | ||
| assert_eq!(decoded.as_bytes(), b"Hello, world"); | ||
|
|
||
| let encoded = decoded.to_der().unwrap(); |
Contributor
There was a problem hiding this comment.
Nice! So it "just works" 😄
But the sad part is Cow<BitStringRef> and "alloc"-gated Cow.
Member
Author
There was a problem hiding this comment.
Not much that can be done about an alloc-gated Cow. You can make the type generic so you can swap out Cow<'a, OctetStringRef> for &'a OctetStringRef>.
I can potentially make BitStringRef work, though it will be somewhat annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a POC that the traits work with
OctetStringRefcc @dishmaker