blake2: restore Blake2bVar/Blake2sVar
#754
Closed
+247
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restores hashes that previously impl'd the now removed `VariableOutput` trait which were removed in #744. They're used by `argon2`. Note the API has been transition from traits to inherent methods, and the implementations have not been restored for other runtime-variable hash functions, just `blake2` due to the need to use `Blake2bVar` in the `argon2` crate.
Member
|
I think we should discourage use of runtime-variable output sizes. In the case of |
Member
Author
|
@newpavlov in the interim I need a stopgap as this is blocking the whole If you can modify If you'd like, I can slap a |
Member
|
Give me ~30 minutes. I will try to draft a fix which does not rely on this PR. If I am not finished by then, you can merge this PR. |
Member
Author
|
@newpavlov wrong PR, I assume |
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Nov 5, 2025
This upgrades `rand_core` to v0.10 prereleases and depends directly on `getrandom` for access to the system RNG. It additionally bumps other crates like `digest` and `blake2` which use the new `crypto-common` with an upgraded `rand_core`. This required restoring some functionality in `blake2` which was used by `argon2`: RustCrypto/hashes#754 This is currently referenced as a git branch until we decide if this is a permanent solution for `argon2` or not, so as to unblock the upgrade.
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Nov 5, 2025
This upgrades `rand_core` to v0.10 prereleases and depends directly on `getrandom` for access to the system RNG. It additionally bumps other crates like `digest` and `blake2` which use the new `crypto-common` with an upgraded `rand_core`. This required restoring some functionality in `blake2` which was used by `argon2`: RustCrypto/hashes#754 This is currently referenced as a git branch until we decide if this is a permanent solution for `argon2` or not, so as to unblock the upgrade.
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Nov 5, 2025
This upgrades `rand_core` to v0.10 prereleases and depends directly on `getrandom` for access to the system RNG. It additionally bumps other crates like `digest` and `blake2` which use the new `crypto-common` with an upgraded `rand_core`. This required restoring some functionality in `blake2` which was used by `argon2`: RustCrypto/hashes#754 This is currently referenced as a git branch until we decide if this is a permanent solution for `argon2` or not, so as to unblock the upgrade.
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Nov 5, 2025
This upgrades `rand_core` to v0.10 prereleases and depends directly on `getrandom` for access to the system RNG. It additionally bumps other crates like `digest` and `blake2` which use the new `crypto-common` with an upgraded `rand_core`. This required restoring some functionality in `blake2` which was used by `argon2`: RustCrypto/hashes#754 This is currently referenced as a git branch until we decide if this is a permanent solution for `argon2` or not, so as to unblock the upgrade.
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Nov 5, 2025
This upgrades `rand_core` to v0.10 prereleases and depends directly on `getrandom` for access to the system RNG. It additionally bumps other crates like `digest` and `blake2` which use the new `crypto-common` with an upgraded `rand_core`. This required restoring some functionality in `blake2` which was used by `argon2`: RustCrypto/hashes#754 This is currently referenced as a git branch until we decide if this is a permanent solution for `argon2` or not, so as to unblock the upgrade.
Member
Author
|
These usages were removed in RustCrypto/password-hashes#739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores hashes that previously impl'd the now removed
VariableOutputtrait which were removed in #744. They're used byargon2.Note the API has been transition from traits to inherent methods, and the implementations have not been restored for other runtime-variable hash functions, just
blake2due to the need to useBlake2bVarin theargon2crate.