Skip to content

Gen2 Production PR: Manual Fix for GENIE timing bug in CAFMaker + Extend existing-data shift in CAFMaker - #199

Open
VCLanNguyen wants to merge 4 commits into
production/sbnd-gen2from
bugfix_gen2_mctiming_merge_correctedopflash
Open

Gen2 Production PR: Manual Fix for GENIE timing bug in CAFMaker + Extend existing-data shift in CAFMaker#199
VCLanNguyen wants to merge 4 commits into
production/sbnd-gen2from
bugfix_gen2_mctiming_merge_correctedopflash

Conversation

@VCLanNguyen

@VCLanNguyen VCLanNguyen commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

  1. Adds SRTrueInteraction.prod_time/.dk2gen field
  2. Adds SRMeVPrtl.prod_time
  3. Assigns rec.mc.nu.generator in CAFMaker_module.cc — previously unset
  4. Adds CorrectMCTiming() (MC only, nu.generator == kGENIE): computes a per-true-neutrino offset_ns = nu.prod_time + nu.dk2gen100/c, applies each slice's matched neutrino's offset to slc.truth, opt0/opt0_sec, barycenterFM, all fmatch, crumbs_result, correctedOpFlash.*, matched CRT tracks
  5. Extends pre-existing data-side shift (SBNDShiftCRTReference/SBNDShiftPMTReference) to also cover opt0_sec, barycenterFM, fmatch*, crumbs_result

Validation:

See slide 1-26 on docdb#49588

Dependency:

Gen2 Production:

sbncode: SBNSoftware/sbncode#675
sbnanaobj: #199
sbndcode: SBNSoftware/sbndcode#967

Develop:

sbncode: SBNSoftware/sbncode#676 -- to mirror description bullet 1/2/3
sbnanaobj: #200 -- to mirror description bullet 1/2/3

Quick checklist

  • Have you run git fetch and pulled the latest changes from the branch you're basing your PR against?
  • If you're adding new classes, have you added them to classes_def.xml in the relevant directory?
  • Have you added a checksum in classes_def.xml to any and all new classes you're implementing, and rebuilt?
  • If you're updating classes, have you incremented the ClassVersion by one compared to develop in classes_def.xml?
  • Have you pinged CAF maintainers to let them know of the changes? @Gianluca Petrillo and @thomas Jones

@VCLanNguyen VCLanNguyen changed the title Add dk2nu production-time and Leg4 baseline fields to SRTrueInteraction Bug Fix in CAFMaker for dk2nu v1_11_00 Sep 25, 2026
@VCLanNguyen
VCLanNguyen marked this pull request as draft September 25, 2026 17:42
@VCLanNguyen VCLanNguyen added the bug Something isn't working label Sep 25, 2026
@VCLanNguyen VCLanNguyen mentioned this pull request Sep 25, 2026
Open
3 of 6 tasks
VCLanNguyen and others added 3 commits September 29, 2026 16:13
@VCLanNguyen @claude
Add MeVPrtl production-time field to SRMeVPrtl
530acbc 
Mirrors the dk2nu prod_time field added to SRTrueInteraction: needed
to recover the BNB beam-bunch offset for MeVPrtl (HNL) truth the same
way it's already done for GENIE. Also fixes the stale [us] doc comment
on `time`, which FillMeVPrtlTruth has always filled in ns.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@VCLanNguyen @claude
Add checksum for SRMeVPrtl ClassVersion 15
580d316 
Filled in by checkClassVersion on build, following the prod_time field
addition.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@VCLanNguyen @claude
Reword SRMeVPrtl.time/.prod_time doc comments to match SRTrueInteraction
40db242 
Mirrors SRTrueInteraction's time/prod_time comment style and phrasing
for the analogous SRMeVPrtl fields.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@VCLanNguyen VCLanNguyen changed the title Bug Fix in CAFMaker for dk2nu v1_11_00 Gen2 Production PR: 1. Manual Fix for GENIE timing bug in CAFMaker, 2. Extend existing-data shift in CAFMaker, 3. Update to SBND LightPropagation Module Sep 30, 2026
@VCLanNguyen VCLanNguyen changed the title Gen2 Production PR: 1. Manual Fix for GENIE timing bug in CAFMaker, 2. Extend existing-data shift in CAFMaker, 3. Update to SBND LightPropagation Module Gen2 Production PR: Manual Fix for GENIE timing bug in CAFMaker + Extend existing-data shift in CAFMaker Sep 30, 2026
@VCLanNguyen VCLanNguyen mentioned this pull request Sep 30, 2026
Open
4 of 7 tasks
@VCLanNguyen
VCLanNguyen marked this pull request as ready for review October 1, 2026 18:56
@VCLanNguyen VCLanNguyen self-assigned this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjones79 tjones79 Awaiting requested review from tjones79
@PetrilloAtWork PetrilloAtWork Awaiting requested review from PetrilloAtWork

At least 1 approving review is required to merge this pull request.

Assignees

@VCLanNguyen VCLanNguyen

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@VCLanNguyen