Repository navigation
Resolve remaining zizmor findings in our workflows - #420
Merged
Merged
Conversation
- Pass matrix values and the workspace path to run steps through env - Use bash as default shell for the release builds - Drop the MinGW cache from the release builds to avoid cache poisoning
eXpl0it3r
force-pushed
the
feature/workflow-hardening
branch
from
October 4, 2026 15:04
3276fd7 to
d16ac52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #418, which didn't catch everything zizmor complains about. With this PR
zizmor --pedanticcomes back clean for all three workflows, except for the container images and actions referenced by tag instead of digest, which is on purpose.ci.yml: Matrix values are passed to therunsteps throughenvinstead of being expanded into the scriptrelease.yml: Usesbashas default shell and$GITHUB_WORKSPACEinstead of${{ github.workspace }}insiderunrelease.yml: Drops the MinGW cache, as a release build shouldn't restore something an untrusted run could've written into the cache, the toolchain is now downloaded on every runNote that the Windows build steps of the release workflow now run in bash instead of PowerShell, the steps that explicitly use
pwshstay as they are.How to test this PR?
CI should succeed.
The release and NuGet workflows don't run for PRs, so they should be checked with a manual run on this branch.