Skip to content

Feat/utsav feedback form#1

Open
vvshk wants to merge 19 commits into
mainfrom
feat/utsav-feedback-form
Open

Feat/utsav feedback form#1
vvshk wants to merge 19 commits into
mainfrom
feat/utsav-feedback-form

Conversation

@vvshk
Copy link
Copy Markdown
Collaborator

@vvshk vvshk commented Feb 19, 2026

No description provided.

@vvshk vvshk requested a review from vendz February 19, 2026 19:52
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @vvshk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature to collect feedback for Utsav events, enhancing the application's ability to gather user insights. It provides a dedicated, user-friendly form for participants to rate their experience across multiple categories and offer suggestions. The feedback mechanism is seamlessly integrated into the existing event booking flow, making it accessible at the appropriate time. Additionally, minor technical updates were made to dependencies and development environment configurations.

Highlights

  • New Utsav Feedback Form: A comprehensive feedback form has been implemented for Utsav events, allowing users to rate various aspects like accommodation, food, program, and provide suggestions for improvement. This form includes star ratings and text input fields.
  • Feedback Form Integration: The new Utsav feedback form is integrated into the event booking cancellation component, providing a 'Give Feedback' button for relevant past events. This button navigates users to the new feedback screen.
  • Routing and Navigation: New routing has been configured for the Utsav feedback screen, making it accessible as a modal with a dynamic ID parameter.
  • Dependency Update: The Expo dependency has been updated to a newer patch version.
  • Development API Endpoint Adjustment: The development API endpoint logic was adjusted to use a local IP address when a PR number is specified, facilitating local testing.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • package.json
    • Updated the 'expo' dependency from '^54.0.9' to '^54.0.31'.
  • src/app/(tabs)/index.tsx
    • Imported 'TouchableOpacity' from 'react-native'.
  • src/app/utsav/_layout.tsx
    • Added a new 'Stack.Screen' for the 'feedback/[id]' route, configured as a modal without a header.
  • src/app/utsav/feedback/[id].tsx
    • Added a new screen component for the Utsav feedback form.
    • Implemented 'UtsavFeedbackData' type and 'getInitialUtsavFeedbackForm' function.
    • Created 'StarRating' and 'FieldLabel' reusable components.
    • Developed the 'UtsavFeedbackForm' component to render all feedback fields with validation.
    • Implemented 'UtsavFeedbackScreen' to handle form state, API calls for access validation and submission, and display loading/error states.
  • src/components/cancel booking/EventBookingCancellation.tsx
    • Imported 'useRouter' from 'expo-router'.
    • Initialized the 'router' hook.
    • Added a console log for 'UTSAV BOOKINGS RESPONSE' in the fetchUtsavs success callback.
    • Modified the condition for displaying the item amount to check if 'item.amount > 0'.
    • Refactored the action buttons to include a 'Give Feedback' button, which navigates to the new feedback screen when 'item?.showFeedback' is true.
    • Adjusted the 'Cancel Booking' button's display condition to use 'item.utsav_start_date' and be part of a new 'Actions Row'.
  • src/utils/HandleApiCall.js
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a feedback form for "Utsavs". The implementation includes a new screen for the form, integration with the existing booking list to show a "Give Feedback" button, and necessary routing changes. The code is generally well-structured, but there are a few critical and high-severity issues that must be addressed. A hardcoded local development URL has been introduced, which will break API calls in production. There's also a console.log statement that should be removed, and a potential bug in promise handling that could cause the app to hang. I've also included some suggestions to improve maintainability and prevent potential race conditions.

Comment thread src/utils/HandleApiCall.js Outdated
Comment thread src/app/utsav/feedback/[id].tsx
Comment thread src/components/cancel booking/EventBookingCancellation.tsx Outdated
Comment thread src/app/utsav/feedback/[id].tsx Outdated
Comment thread src/app/utsav/feedback/[id].tsx Outdated
@vvshk vvshk marked this pull request as ready for review May 22, 2026 06:49
2. removed future adhyayan field from adhyayan feedback
3 . hide give feedback button once feedback is submitted - for both utsav and adhyayan
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@vendz vendz force-pushed the feat/utsav-feedback-form branch from 468e712 to 72f906b Compare May 23, 2026 01:07
@vvshk
Copy link
Copy Markdown
Collaborator Author

vvshk commented May 23, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a new multi-step feedback system for Adhyayan and Utsav events using a modular SteppedFeedback component. It refactors the sign-in screen for better keyboard handling, introduces new UI variants for buttons and form fields, and adds support for feedback deep links and font assets. Reviewers identified several improvement opportunities, including making animation refs dynamic, enhancing type safety by avoiding any, removing redundant state resets and debug logs, and replacing hardcoded UI characters with vector icons.

Comment thread src/components/SteppedFeedback/useSteppedFeedback.ts
Comment thread src/app/(auth)/sign-in.tsx
Comment thread src/app/utsav/feedback/[id].tsx Outdated
Comment thread src/components/SteppedFeedback/index.tsx Outdated
Comment thread src/components/cancel booking/EventBookingCancellation.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants