make allocpool check the allocations file #3839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrassler
previously approved these changes
Mar 18, 2020
Contributor
jgrassler
left a comment
jgrassler
left a comment
There was a problem hiding this comment.
Looks sound from a functional point of view. Feel free to address my nit or leave it as it is :-)
scripts/mkcloudhost/allocpool
Outdated
| my $n=$d; | ||
| $n=~ s/$pooldir\///; | ||
| while(<$fha>) { | ||
| if(/^[a-z]*$n jenkins$/) { |
Contributor
There was a problem hiding this comment.
nit: you could use an explicit loop variable here for readability. I suspect that most people who don't deal with Perl on a regular basis might not be familiar with the subtleties of $_ :-)
Contributor
Author
There was a problem hiding this comment.
Done, please re-review
as sometimes people change allocations, but not the contents of the pool directory or the other way around. Make it check both, to ensure someones running mkcloud is not replaced.
JanZerebecki
force-pushed
the
check-allocations
branch
from
9620f62 to
2278e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as sometimes people change allocations, but not the contents of the pool
directory or the other way around. Make it check both, to ensure
someones running mkcloud is not replaced.