feat(themes): channel visibility for home blocks - #1019
Draft
eslamoo wants to merge 7 commits into
Draft
Conversation
Contributor
Up to standards ✅🟢 Issues
|
bakrimoharram
force-pushed
the
feature/TD-13969-channel-visibility
branch
from
August 6, 2026 08:15
ddf9d6d to
8eb2e89
Compare
Contributor
|
@greptile-apps review |
…annel-visibility # Conflicts: # public/app.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds channel visibility to theme-raed home blocks. A merchant can now show a component on Desktop only, Mobile web only, or both, without writing custom CSS.
Jira: https://salla-dev.atlassian.net/browse/TD-13969
How
s-hide-on-mobile/s-hide-on-desktoputility pair insrc/assets/styles/05-utilities/channel-visibility.scss, breaking at 768px (Tailwindmd).<section>derives its class inline fromcomponent.channel_visibility: { mobile, desktop }, which the backend injects.Notes
md:hidden. The class comes from a variable, so Tailwind's JIT content scan would purge it.component.channel_visibility and not ...guard means a missing object emits no class, so legacy blocks stay visible everywhere.not flagrather thanflag == false: Twig's loose==matchesnull, which would hide every legacy block.Test
s-block--full-bgblock (brands,featured-products-style2) to confirm no empty coloured strip.Stack
Part of the TD-13969 / TD-15122 home-blocks stack. Main PR: Dashboard #27853.
This PR carries only the TD-13969 channel-visibility styling; the TD-15122 versions work is backend-only.