Conversation
Up to standards ✅🟢 Issues
|
Resolve preview conflicts by keeping the PR-readiness fixes already merged to main, including the CI script location, unit test location, and manifest alias policy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use script-scoped Pester variables for shared BeforeAll data so targeted PSScriptAnalyzer checks are clean after merging main into preview. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Pester unit tests for the MkDocs navigation update script, primarily adjusting variable scoping/initialization inside test contexts.
Changes:
- Moves module manifest path setup into the
Get-CategorizedFunctiontest context. - Persists values from
BeforeAllblocks using script-scoped variables for reuse across multipleItblocks.
Rename the script-scoped categorized-functions test variable to plural form so the Pester assertions read clearly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR now represents the remaining delta after merging current
mainintopreviewand resolving the original preview conflicts with the PR-readiness fixes from #192.Current change:
src/Tests/Unit/Update-MkDocsNavigation.Tests.ps1to use script-scoped variables for shared PesterBeforeAlldata and clearer categorized-functions naming.The earlier preview workflow, MkDocs navigation, manifest export, and documentation changes were superseded by #192 and are already on
main.