Also fail on Pester block/container failures (not just failed tests) - #207
Merged
Merged
Conversation
In Pester 5 a run has three independent failure counts. Gating only on FailedCount misses FailedBlocksCount (BeforeAll/AfterAll) and FailedContainersCount (files that fail to discover/load), so a failing BeforeAll or an unloadable test file passes the build green. This adds those counts to the gate. Generated with AI (GitHub Copilot CLI). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
Owner
|
Thanks, @nohwnd! |
SamErde
approved these changes
Jul 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the build’s Pester result gating to treat failed blocks (BeforeAll/AfterAll) and failed containers (discovery/load errors) as build failures, not just failed It tests—aligning the build outcome with Pester 5’s overall pass/fail semantics.
Changes:
- In the
Testbuild task, gate onFailedCount + FailedBlocksCount + FailedContainersCount. - In the
IntegrationTestbuild task, gate onFailedCount + FailedBlocksCount + FailedContainersCount.
Comment on lines
+355
to
356
| $numberFails = ($testResults.FailedCount + $testResults.FailedBlocksCount + $testResults.FailedContainersCount) | ||
| Assert-Build($numberFails -eq 0) ('Failed "{0}" unit tests.' -f $numberFails) |
Comment on lines
+604
to
605
| $numberFails = ($testResults.FailedCount + $testResults.FailedBlocksCount + $testResults.FailedContainersCount) | ||
| Assert-Build($numberFails -eq 0) ('Failed "{0}" unit tests.' -f $numberFails) |
Owner
|
@nohwnd, the Copilot suggestions here are legit and will matter more for some projects than others (Maester). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been seeing this commonly across Pester 5 build scripts and I'm fixing it where it looks like it could hide real failures.
In Pester 5 a run reports three independent failure counts:
FailedCount— failed tests (It)FailedBlocksCount— failedBeforeAll/AfterAllFailedContainersCount— files that error during discovery / fail to loadGating on only
FailedCountmeans aBeforeAllthat throws, or a test file that fails to load, leavesFailedCount = 0and the build passes green despite real failures. Pester itself derives the overall pass/fail from the sum of all three.This change includes all three counts in the gate. Display/log messages are left unchanged.