Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revises - and hopefully improves - the documentation in the fuzzy_sphere model file, and was inspired by recent interactions between the PR author and some SasView Users which highlighted misunderstandings about the applicability of the model and the meaning of the radius parameter.
This PR does not change the calculation code.
The revised documentation has been checked by locally building the sasmodel docs. A pdf of the revised documentation is available here: revised_fuzzy_sphere_documentation.pdf (NB: the print webpage to pdf utility has messed with the formatting a little).
An approving reviewer should add their name and date to the bottom of fuzzy_sphere.py before merging!