Skip to content

fix(postgresql/guides) plan change process is restarting follower instances first#3745

Merged
curzolapierre merged 1 commit into
masterfrom
fix/guides/postgresql_plan-change_restarts_follower_first
May 12, 2026
Merged

fix(postgresql/guides) plan change process is restarting follower instances first#3745
curzolapierre merged 1 commit into
masterfrom
fix/guides/postgresql_plan-change_restarts_follower_first

Conversation

@curzolapierre
Copy link
Copy Markdown
Member

No description provided.

@curzolapierre curzolapierre self-assigned this May 11, 2026
@curzolapierre curzolapierre requested a review from Frzk May 11, 2026 12:36
Comment on lines +48 to +49
When changing for a Business plan, the platform starts additional instances
with the targeted size. If necessary, it then reboots the previously existing
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question:
When changing from a Starter plan to a Business one, we switch from a single-instance setup to a primary+follower setup, don't we?
So "additional instances" is the new "follower instance", and "previously existing instance" it the "primary" one, aren't they?
(if so, I don't get why this change)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When changing from a Starter plan to a Business one, we switch from a single-instance setup to a primary+follower setup, don't we?

Yes correct

So "additional instances" is the new "follower instance", and "previously existing instance" it the "primary" one, aren't they?

To be more precise: "additional instances" are the new "follower instance(s)". This is the only little change that I wanted to bring. But from my first read the change was obvious, now it's not the case anymore 😅

it the "primary" one, aren't they?

Yes correct

So I'm suggesting a change: a24fdec, WDYT?

@curzolapierre curzolapierre requested a review from Frzk May 12, 2026 09:49
Copy link
Copy Markdown
Contributor

@Frzk Frzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@curzolapierre curzolapierre force-pushed the fix/guides/postgresql_plan-change_restarts_follower_first branch 2 times, most recently from 0ec03f0 to abf956c Compare May 12, 2026 13:46
@curzolapierre curzolapierre force-pushed the fix/guides/postgresql_plan-change_restarts_follower_first branch from abf956c to c0db29d Compare May 12, 2026 13:49
@curzolapierre curzolapierre merged commit 3bdfc00 into master May 12, 2026
3 of 4 checks passed
@curzolapierre curzolapierre deleted the fix/guides/postgresql_plan-change_restarts_follower_first branch May 12, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants