Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 92 92
Lines 9524 9529 +5
=======================================
+ Hits 8967 8972 +5
Misses 557 557 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| #ifdef GMGPOLAR_USE_MUMPS | ||
| #include "dmumps_c.h" | ||
| #include "mpi.h" | ||
| #endif |
There was a problem hiding this comment.
Why are the includes no longer needed?
There was a problem hiding this comment.
They are moved in the main
smoother.h.
Previously they were in
smootherTake.h and smootherGive.h
There was a problem hiding this comment.
What strategy are you using for the includes? There are several that are common in different repos, e.g.
- include what you use
- include as little as possible
There was a problem hiding this comment.
As the compile time is not a big issue in this project and the custom test cases take basically the most time, I am including the things that are used in that file.
You could go the effort and move some more things to the .cpp or do forward declarations, but it's likely not worth it.
And since Take and Give are pretty similar, I just put all includes in the main virtual header to keep the code shorter where it matters.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):