Use Kokkos::Parallel in SmootherGive ApplyAscOrtho

[julianlitz]

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

• There is at least one issue associated with the pull request.
• New code adheres with the coding guidelines
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

• Tests for new functionality has been added
• A local test was succesful

If new functionality was added:

• There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

• Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

• Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

• Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
• The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
• There are appropriate unit tests and they pass.
• The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
• Coverage report for new code is acceptable.
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

[julianlitz]

Most time in GMGPolar is spend in the applyAscOrtho.
Thus I also reduced the branches.

I separated the original function, containing both inside and outside.
The +=2 always took the inside path while +=4 handles the outside nodes.

[codecov]

Codecov Report

❌ Patch coverage is 98.91304% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.46%. Comparing base (13c3310) to head (decc8b1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
include/Smoother/SmootherGive/applyAscOrtho.inl	98.89%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   89.44%   89.46%   +0.02%     
==========================================
  Files          79       79              
  Lines        9152     9200      +48     
==========================================
+ Hits         8186     8231      +45     
- Misses        966      969       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[julianlitz]

First try 😌

[EmilyBourne]

On v100 at 72c081c:

100% tests passed, 0 tests failed out of 268

[EmilyBourne]

As far as I can tell the logic seems to be intact

[julianlitz]

@EmilyBourne For the extrapolated version I will probably keep the code how it is without making the separation like done here. 😉

[EmilyBourne]

At 574abad on v100:

100% tests passed, 0 tests failed out of 268

[julianlitz]

@EmilyBourne I think that we can actually merge the "Outside" loops together in Rank 2.
I don't think that it will introduce race conditions.

Only the "Inside" Loops would need to remain serial.