Skip to content

Conversation

@tats-u
Copy link

@tats-u tats-u commented Oct 4, 2025

Fixes #7201

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • Added Comrak 0.43.0 package for Windows (x64 and ARM64), providing the comrak CLI.
    • Secure SHA256-verified downloads per architecture to ensure file integrity.
    • Built-in automatic update and version-check support for streamlined maintenance and upgrades.

@coderabbitai
Copy link

coderabbitai bot commented Oct 4, 2025

Walkthrough

Adds a new Scoop manifest bucket/comrak.json for Comrak v0.43.0 containing metadata (version, description, homepage, license), a bin entry comrak.exe, architecture-specific 64bit and arm64 MSVC release URLs with SHA256, checkver pointing to GitHub, and autoupdate entries using "kivikakk".

Changes

Cohort / File(s) Summary
New Scoop manifest
bucket/comrak.json
New Comrak v0.43.0 manifest: metadata (version, description, homepage, license), bin exposing comrak.exe, architecture-specific 64bit and arm64 MSVC release URLs with SHA256, checkver referencing the GitHub repo, and autoupdate with per-arch URLs (uses "kivikakk").

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop with joy through code and crate,
A tiny manifest — tidy, straight.
Comrak arrives in binary light,
Hashes aligned, downloads take flight.
🐇📦✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description includes the checklist and references issue #7201 but lacks a summary of the actual changes at the top and does not use the exact 'Closes #XXXX' or 'Relates to #XXXX' phrasing required by the template. It also retains placeholder comments without detailing what was implemented. Add a concise summary of the manifest additions immediately below the title, replace "Fixes #7201" with the required "Closes #7201" or "Relates to #7201" label, and remove or replace leftover placeholder comments to fully conform to the description template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title follows the <manifest-name>: <summary> convention by stating 'comrak' and accurately describing the addition of a new app. It clearly identifies the primary change for maintainers scanning the repository history.
Linked Issues Check ✅ Passed The manifest file defines version 0.43.0 of Comrak with proper metadata, homepage, license, and architecture-specific download URLs and SHA256 hashes, fulfilling the installation and metadata criteria from issue #7201. It provides a standard, script-free install and meets popularity and interface requirements as specified.
Out of Scope Changes Check ✅ Passed All modifications are confined to adding the bucket/comrak.json manifest file in alignment with the linked issue objectives, and no other files or unrelated code were altered. There are no out-of-scope changes present.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71e597d and 966939f.

📒 Files selected for processing (1)
  • bucket/comrak.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/comrak.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

comrak

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28ac7c9 and 7a422cc.

📒 Files selected for processing (1)
  • bucket/comrak.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/comrak.json

[error] 1-1: Autoupdate: Checkver attempted to query the releases API and returned 404 (Not Found). Could not find hash in API response and autoupdate failed.

@tats-u
Copy link
Author

tats-u commented Oct 4, 2025

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

Invalid manifests

  • comrak

Check the full log for details.

@tats-u
Copy link
Author

tats-u commented Oct 4, 2025

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

comrak

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@tats-u
Copy link
Author

tats-u commented Oct 4, 2025

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

comrak

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@tats-u
Copy link
Author

tats-u commented Oct 4, 2025

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

All changes look good.

Wait for review from human collaborators.

comrak

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Comrak

1 participant