chore: Update compatible checkver to github #7380
Conversation
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with atomicparsley
cloc
k0s
knative
lychee
suanpan
typst
yazi
|
stevehipwell
force-pushed
the
github-checkver
branch
from
e2ffdba to
05c4435
Compare
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with atomicparsley
cloc
k0s
knative
lychee
suanpan
typst
yazi
|
Signed-off-by: Steve Hipwell <[email protected]>
stevehipwell
force-pushed
the
github-checkver
branch
from
05c4435 to
c2278f2
Compare
|
/verify |
|
All changes look good. Wait for review from human collaborators. atomicparsley
cloc
k0s
knative
lychee
suanpan
typst
yazi
|
|
That's quite a lot of changes, so I'll need some extra time to review and test everything thoroughly. ⏳ |
This comment was marked as resolved.
This comment was marked as resolved.
@Lutra-Fs I know this has been discussed further in ScoopInstaller/Scoop#6559 but is this the current behaviour? |
|
No, it will use GitHub API when |
@Lutra-Fs does that not mean that the regex needs to work in both contexts? |
|
I think "/releases/tag/" or "tag/" match are working well on both context. So maybe we'd better keep better using that unless we modified the GitHub checkver behaviour. |
|
One issue we previously discussed in the core repository is that when checkver falls back to HTML parsing, there's currently no logging to inform users why this happens, such as not having correctly set up their Additionally, I believe using the GitHub API by default is more intuitive than HTML parsing. This is technical debt we need to address. Since the GitHub API provides anonymous access (albeit with a lower rate limit), it should work fine for normal users even if they don't set a |
| "url": "https://github.com/k0sproject/k0s/releases", | ||
| "regex": "v([\\d.]+\\+k0s[\\d.]+)" | ||
| "github": "https://github.com/k0sproject/k0s", | ||
| "regex": "v(\\d+\\.\\d+\\.\\d+\\+k0s\\.\\d+)" |
There was a problem hiding this comment.
Should we also use
| "regex": "v(\\d+\\.\\d+\\.\\d+\\+k0s\\.\\d+)" | |
| "regex": "/releases/tag/v(\\d+\\.\\d+\\.\\d+\\+k0s\\.\\d+)" |
here?
2 participants
This PR updates manifests to the GitHub checkver pattern where possible. This is based on the discussion on #7379.
CC @Lutra-Fs
<manifest-name[@version]|chore>: <general summary of the pull request>