fix(security): protect OUI denylist admin endpoints#122
Merged
Scottcjn merged 1 commit intoScottcjn:mainfrom Feb 12, 2026
Merged
Conversation
Contributor
Author
|
Added minimal auth guard for /admin/oui_deny/* endpoints. Prior to patch, unauthenticated POST /admin/oui_deny/add and /admin/oui_deny/remove succeeded on live node; after patch these should return 403 unless X-API-Key matches RC_ADMIN_KEY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security hardening discovered during red-team bounty #57.
Issue
/admin/oui_deny/list,/admin/oui_deny/add,/admin/oui_deny/removewere reachable without admin authentication, allowing unauthenticated modification of the OUI denylist.Fix
Require admin auth (
X-API-KeymatchingRC_ADMIN_KEY) for all OUI denylist endpoints.Validation
Manual reproduction against live node prior to patch:
After patch, these should return 403 when not authenticated.
Related bounty: Scottcjn/rustchain-bounties#57