light-client: browser wallet + Ed25519 signed transfers#155
Merged
Scottcjn merged 2 commits intoScottcjn:mainfrom Feb 13, 2026
Merged
light-client: browser wallet + Ed25519 signed transfers#155Scottcjn merged 2 commits intoScottcjn:mainfrom
Scottcjn merged 2 commits intoScottcjn:mainfrom
Conversation
Scottcjn
requested changes
Feb 13, 2026
Owner
Scottcjn
left a comment
There was a problem hiding this comment.
Changes Requested — Promising concept, needs refinement
A browser-based light client with Ed25519 signed transfers is interesting, but:
- Verify against live API: Has this been tested against
https://50.28.86.131? Include screenshots or curl output - Key management concerns: How are private keys stored in the browser? LocalStorage is not secure for Ed25519 keys
- Endpoint compatibility: The transfer endpoint format must match our server's
/wallet/transfer/signedschema exactly (check field names:from_address,to_address,amount_rtc,nonce,signature,public_key) - No bundled dependencies: If using external libraries (tweetnacl, etc.), document how they're loaded
This could be a great contribution — please address these points and resubmit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements bounty #62 (light client):
Local E2E test: