feat: sort dining locations by distance (IN PROGRESS) #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjain2025 is attempting to deploy a commit to the ScottyLabs Team on Vercel. A member of the Team first needs to authorize it. |
cirex-web
reviewed
Nov 16, 2025
Comment on lines
+29
to
+58
| if (location.name === "Stack'd Dessert Bar" && stackUnderground?.coordinates) { | ||
| return { | ||
| ...location, | ||
| coordinates: stackUnderground.coordinates, | ||
| }; | ||
| } | ||
| if (location.name === 'Zebra Lounge' && exchange?.coordinates) { | ||
| return { | ||
| ...location, | ||
| coordinates: exchange.coordinates, | ||
| }; | ||
| } | ||
| if (location.name === 'Sweet Plantain' && tasteOfIndia?.coordinates) { | ||
| return { | ||
| ...location, | ||
| coordinates: tasteOfIndia.coordinates, | ||
| }; | ||
| } | ||
| if (location.name === "De Fer Coffee & Tea At Resnik" && tasteOfIndia?.coordinates) { | ||
| return { | ||
| ...location, | ||
| coordinates: tasteOfIndia.coordinates, | ||
| }; | ||
| } | ||
| if (location.name === 'E.a.t. (evenings At Tepper) - Rohr Commons' && tepperTaqueria?.coordinates) { | ||
| return { | ||
| ...location, | ||
| coordinates: tepperTaqueria.coordinates, | ||
| }; | ||
| } |
Collaborator
There was a problem hiding this comment.
are these coordinate overwrites here because cmumaps can't accept the non-ovewritten coordinates?
cirex-web
reviewed
Nov 16, 2025
Comment on lines
+120
to
+128
| server: { | ||
| proxy: { | ||
| '/api/cmu-maps': { | ||
| target: 'https://rust.api.maps.scottylabs.org', | ||
| changeOrigin: true, | ||
| rewrite: (path) => path.replace(/^\/api\/cmu-maps/, ''), | ||
| secure: true, | ||
| }, | ||
| }, |
Collaborator
There was a problem hiding this comment.
interesting! why proxy cmumaps requests through cmueats this way?
cirex-web
reviewed
Nov 16, 2025
Comment on lines
+1
to
+32
| interface CMUMapsApiResponse { | ||
| Fastest: { | ||
| path: { | ||
| path: Array<{ | ||
| id: string; | ||
| coordinate: { | ||
| latitude: number; | ||
| longitude: number; | ||
| }; | ||
| floor: { | ||
| buildingCode: string; | ||
| level: string; | ||
| }; | ||
| roomId: string; | ||
| neighbors: Record< | ||
| string, | ||
| { | ||
| dist: number; | ||
| toFloorInfo: any; | ||
| } | ||
| >; | ||
| }>; | ||
| distance: number; | ||
| }; | ||
| instructions: Array<{ | ||
| action: string; | ||
| distance: number; | ||
| node_id: string; | ||
| }>; | ||
| }; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
could we write this as a zod schema so we can parse and validate the api response for full typesafety? (or if cmumaps has an openapi schema, we can use that as well)
cirex-web
reviewed
Nov 16, 2025
| @media screen and (max-width: 900px) { | ||
| .Locations-header__filters { | ||
| flex-direction: column; | ||
| gap: 0.5rem; |
Collaborator
There was a problem hiding this comment.
just an fyi, cmueats has opted to use px for everything for consistency
Collaborator
|
goated feature |
cirex-web
reviewed
Nov 16, 2025
Comment on lines
+70
to
+77
| const getPriority = (state: LocationState) => { | ||
| if (state === LocationState.OPEN | ||
| || state === LocationState.CLOSES_SOON) return 0; | ||
| if (state === LocationState.OPENS_SOON) return 1; | ||
| if (state === LocationState.CLOSED | ||
| || state === LocationState.CLOSED_LONG_TERM) return 2; | ||
| return 3; | ||
| }; |
Collaborator
There was a problem hiding this comment.
good - although this feels inverted since higher priority elements are sorted last lmao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for testing on mobile (feature in progress)