Skip to content

Conversation

@mash20-dot
Copy link

This PR replaces the first part of the Bash script upgrade_containers.sh with a Python script as described in issue #1919. The new script replicates the existing functionality and improves portability and maintainability.

Fixes #1919

@mash20-dot mash20-dot requested a review from a team as a code owner August 5, 2025 14:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2025

@nicomiguelino
Copy link
Contributor

@mash20-dot, great work! Let me test and review your changes. I'll get back to you as soon as I can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this to update_containers.py.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the part that pulls the Docker containers in this Python script.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

@@ -0,0 +1,44 @@
import os
Copy link
Contributor

@nicomiguelino nicomiguelino Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a #!/usr/bin/env python3 at the beginning of the file:

Suggested change
import os
#!/usr/bin/env python
import os

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert bin/upgrade_containers.sh to a Python script.

2 participants