Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/CODE_REVIEW_AUDIT_2026-07-29.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Code Review Audit Request - 2026-07-29

This branch exists only to trigger external review on the current `main` state.

Audit scope:

- README badges, About metadata, and governance docs consistency.
- Test-suite correctness and missing validation gates.
- Secret-safety boundary: no `.env`, token, cookie, cPanel, payment, or provider secret exposure.
- SecuredMe Education gateway compatibility without direct secret storage.
- Pre-alpha wording, human-review boundary, and student/teacher safety posture.
- Repository-specific architecture risks and stale documentation.

No application behavior is intentionally changed by this audit branch.
2 changes: 1 addition & 1 deletion .github/workflows/ci-datadog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Install package dependencies
run: |
python -m pip install --upgrade pip
python -m pip install -e ".[dev]"
python -m pip install -e ".[dev,api]"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Install httpx before collecting the API tests

On a fresh GitHub runner, .[dev,api] still does not install httpx: the api extra only declares FastAPI, Uvicorn, and Pydantic, while tests/test_api.py imports FastAPI's Starlette-based TestClient, which requires httpx. Consequently python -m pytest stops during collection with ModuleNotFoundError: No module named 'httpx', leaving this validation job red; add httpx to the test/development dependencies or install the appropriate FastAPI standard extra.

Useful? React with 👍 / 👎.


- name: Run public unit tests with package dependencies
run: python -m pytest
Expand Down
2 changes: 2 additions & 0 deletions SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ Useful report content:

Never commit or disclose API keys, OAuth tokens, cookies, browser sessions, .env values, passwords, cPanel details, payment credentials, private corpora, raw student records, production logs, or unpublished research material.

Do not commit Datadog API keys, OpenAI keys, GitHub tokens, cPanel credentials, PayPal credentials, or any other operational secret. This MVP is not a production cryptographic system.

The shared SecuredMe gateway may route configured audit, observability, and assistant handoff metadata. This repository must not expose gateway secrets, provider tokens, or private operator state in README files, tests, logs, exceptions, screenshots, or issue reports.

## AI And Human Review Boundary
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dependencies = ["cryptography>=42.0"]
[project.optional-dependencies]
dev = ["pytest>=8.0"]
e2b = ["e2b>=1.0.0"]
api = ["fastapi>=0.110", "uvicorn>=0.29", "pydantic>=2.0"]
api = ["fastapi>=0.110", "uvicorn>=0.29", "pydantic>=2.0", "httpx>=0.27"]

[project.scripts]
ffed-qlc = "ffed_qlc.cli:main"
Expand Down
Loading