[gui] Show origin quality grade in scolv and scesv with tooltip breakdown#194
Draft
comoglu wants to merge 5 commits intoSeisComP:mainfrom
Draft
[gui] Show origin quality grade in scolv and scesv with tooltip breakdown#194comoglu wants to merge 5 commits intoSeisComP:mainfrom
comoglu wants to merge 5 commits intoSeisComP:mainfrom
Conversation
Default comment ID to "quality" so the grade written by scoriginquality is visible in the hypocenter panel without any display.origin.comment configuration. Label defaults to "Quality:". Both remain overridable via the existing display.origin.comment.* config keys.
Default the comment ID to "quality" in originlocatorview so the grade written by scoriginquality is visible on the Location tab alongside RMS, azimuthal gap and min. distance, without any olv.display.origin.comment configuration. Label defaults to "Quality:". Overridable via olv.display.origin.comment.id and display.origin.comment.label.
Hover over the grade value to see which parameters drove the grade: Az. Gap: 76.3° → A Sec. Gap: 115.1° → B RMS: 0.937 s → D ... Hover over the "Quality:" label to see the full threshold table. scoriginquality stores grade + breakdown in a single comment using newline as separator; the C++ display code splits on the first newline.
… breakdown The commit dialog pre-populates the quality dropdown from the existing comment text. Since scoriginquality stores a multi-line comment (grade on line 1, per-parameter breakdown after), the full text was shown in the dropdown instead of just the grade letter. - Strip everything after the first newline when reading comment text into the commit dialog dropdown - Compare only the first line when deciding whether the analyst changed the grade, so an unchanged selection does not overwrite the breakdown
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shows the origin quality grade (written by
scoriginquality) by default inboth the scolv Location tab and the scesv hypocenter panel, with no
configuration required.
Changes
eventsummaryview(scesv hypocenter panel):"quality", label to"Quality:"display.origin.comment.idanddisplay.origin.comment.labeloriginlocatorview(scolv Location tab):"quality", label to"Quality:"olv.display.origin.comment.idanddisplay.origin.comment.label"Quality:"label shows the full threshold tableTooltip support (both views):
scoriginqualitystores grade + breakdown in a single comment using\nas separator (grade letter on line 1, one parameter per line after)
\n: label shows the grade letter,setToolTip()shows the full per-parameter breakdown on hoverExample tooltip on hover over the grade value:
Related PRs
comoglu/main:feature/scoriginquality([python] Add scoriginquality: automatic A/B/C/D origin quality grading main#117)Test plan
display.origin.comment.id = myCustomID— confirm custom comment still displays