Skip to content

[gui] Show origin quality grade in scolv and scesv with tooltip breakdown#194

Draft
comoglu wants to merge 5 commits intoSeisComP:mainfrom
comoglu:feature/eventsummaryview-quality
Draft

[gui] Show origin quality grade in scolv and scesv with tooltip breakdown#194
comoglu wants to merge 5 commits intoSeisComP:mainfrom
comoglu:feature/eventsummaryview-quality

Conversation

@comoglu
Copy link
Copy Markdown
Contributor

@comoglu comoglu commented Apr 18, 2026

Summary

Shows the origin quality grade (written by scoriginquality) by default in
both the scolv Location tab and the scesv hypocenter panel, with no
configuration required.

Changes

eventsummaryview (scesv hypocenter panel):

  • Default comment ID changed to "quality", label to "Quality:"
  • Both remain overridable via display.origin.comment.id and
    display.origin.comment.label

originlocatorview (scolv Location tab):

  • Default comment ID changed to "quality", label to "Quality:"
  • Both remain overridable via olv.display.origin.comment.id and
    display.origin.comment.label
  • Static tooltip on the "Quality:" label shows the full threshold table

Tooltip support (both views):

  • scoriginquality stores grade + breakdown in a single comment using \n
    as separator (grade letter on line 1, one parameter per line after)
  • The display code splits on the first \n: label shows the grade letter,
    setToolTip() shows the full per-parameter breakdown on hover

Example tooltip on hover over the grade value:

Az. Gap: 76.3° → A
Sec. Gap: 115.1° → B
RMS: 0.937 s → D
Stations: 12 → A
Min. Dist: 18.2° → A
Horiz. Unc.: 7.4 km → B

Related PRs

Test plan

  • Start scoriginquality + scolv; locate an event; confirm "Quality: B" (or similar) appears on Location tab without any config
  • Hover over the grade value — confirm per-parameter breakdown tooltip
  • Hover over "Quality:" label — confirm threshold table tooltip
  • Start scesv; confirm grade appears in hypocenter panel
  • Hover grade in scesv — confirm breakdown tooltip
  • Set display.origin.comment.id = myCustomID — confirm custom comment still displays

comoglu added 3 commits April 18, 2026 09:00
Default comment ID to "quality" so the grade written by scoriginquality
is visible in the hypocenter panel without any display.origin.comment
configuration. Label defaults to "Quality:". Both remain overridable
via the existing display.origin.comment.* config keys.
Default the comment ID to "quality" in originlocatorview so the grade
written by scoriginquality is visible on the Location tab alongside RMS,
azimuthal gap and min. distance, without any olv.display.origin.comment
configuration. Label defaults to "Quality:". Overridable via
olv.display.origin.comment.id and display.origin.comment.label.
Hover over the grade value to see which parameters drove the grade:
  Az. Gap: 76.3° → A
  Sec. Gap: 115.1° → B
  RMS: 0.937 s → D
  ...

Hover over the "Quality:" label to see the full threshold table.

scoriginquality stores grade + breakdown in a single comment using newline
as separator; the C++ display code splits on the first newline.
@cla-bot cla-bot Bot added the cla-signed The CLA has been signed by all contributors label Apr 18, 2026
… breakdown

The commit dialog pre-populates the quality dropdown from the existing
comment text. Since scoriginquality stores a multi-line comment (grade on
line 1, per-parameter breakdown after), the full text was shown in the
dropdown instead of just the grade letter.

- Strip everything after the first newline when reading comment text into
  the commit dialog dropdown
- Compare only the first line when deciding whether the analyst changed
  the grade, so an unchanged selection does not overwrite the breakdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed by all contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant