[scautoloc] Export secondaryAzimuthalGap in OriginQuality

[comoglu]

Problem

scautoloc computes the secondary azimuthal gap internally via determineAzimuthalGaps() and uses it as a rejection criterion, but the value was never written into OriginQuality when exporting the origin to SeisComP. As a result, scautoloc origins always have secondaryAzimuthalGap unset — unlike stdloc and scrtdd which both populate it.

This was confirmed as an oversight by @jsaul:

"Certainly an oversight. There is determineAzimuthalGaps() and geoProperties(); the latter was implemented by someone else."

Fix

Call determineAzimuthalGaps() in convertToSC() (sc3adapters.cpp) and set secondaryAzimuthalGap on the exported OriginQuality. The function was already available and correct — it just wasn't called at export time.

Related

Companion PR in SeisComP/common adds a standalone computeAzimuthalGaps(azimuths, primary*, secondary*) library function so the algorithm has a single home, as @jsaul suggested: SeisComP/common#193

[gempa-jabe]

Now the azimuthal gap will be computed two times in geoProperties and in determineAzimuthalGaps? Wouldn't it make sense to fix both methods or find a common strategy? Both methods were implemented back in 2008 and even fixed in 2024 ...

[jsaul]

This is the exact idea, to get rid of redundant code by using the compile().

[gempa-jabe]

So this PR is a draft and not about to be merged?

[comoglu]

One thing I'd like to understand better: in the autoloc context, are DataModel::Pick objects registered in the global public object store at the point convertToSC() is called? compile() relies on Pick::Find() for station counts, and I noticed the Pick::Find() block in convertFromSC() was commented out with a note (german) . Wondering if that affects the station count fields if we go the compile() route.

[comoglu]

I converted the PR to Draft until I understand that part better.