Minor code fix in import_actions_utils.py#43
Open
mmulchandani wants to merge 1 commit intoSeldonIO:masterfrom
mmulchandani:cli_userid_itemid_swap_fit
Open
Minor code fix in import_actions_utils.py#43mmulchandani wants to merge 1 commit intoSeldonIO:masterfrom mmulchandani:cli_userid_itemid_swap_fit
mmulchandani wants to merge 1 commit intoSeldonIO:masterfrom
mmulchandani:cli_userid_itemid_swap_fit
Conversation
…t_userid"] and action["client_itemid"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
action["client_userid"] = f["item_id"]changed to =>action["client_userid"] = f["user_id"]action["client_itemid"] = f["user_id"]changed to =>action["client_itemid"] = f["item_id"]It is a minor error and doesn't seem to impact the output, since the model build doesn't seem to be using the client_userid and client_itemid fields. I did verify the first few lines of the actions.json file generated after the fix and it looked correct.
I ran the ml100k example and the recommendations generated after the fix were similar to those before the fix.