Add support for a tag suffix in values #234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when replicating the s1 registry Signed-off-by: Kai Fink <[email protected]>
Collaborator
|
Can we use the current tag param? |
Author
Yes could definetly use the current tag param, but the downside is, that you always need to maintain your s1 version in two different locations(helm chart version + helm values). |
Collaborator
|
@4ch3los Thanks for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: This pr adds a additional values field, to provide a suffix for the tag, like -ga, -ea, ... This helps when replicating the images from the s1 registry.
When directly replicating the images from containers.sentinelone.net, images get suffixed with their release state (ga/ea). This resulst in the need to adjust the tag values for each upgrade. With this pr you can just provide -ga/-ea as suffix for you tag and simply update the helm chart,