Skip to content

feat: add the accept-ranges header to 304 requests #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SerenModz21 merged 1 commit into from
Apr 1, 2026
+6 −6
Merged

feat: add the accept-ranges header to 304 requests #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,19 @@ export function cache(): Middleware {
const response = await cache.match(req);

if (response) {
// headers are immutable, so we need to clone the headers
// to add the Accept-Ranges header for range requests
const headers = new Headers(response.headers);
headers.set("Accept-Ranges", "bytes");

if (c.req.header("If-None-Match") === response.headers.get("ETag")) {
return new Response(null, {
status: 304,
statusText: "Not Modified",
headers: response.headers,
headers,
});
}

// headers are immutable, so we need to clone the headers
// to add the Accept-Ranges header for range requests
const headers = new Headers(response.headers);
headers.set("Accept-Ranges", "bytes");

return new Response(response.body, {
status: response.status,
statusText: response.statusText,
Expand Down
Loading