Draft
Conversation
# Conflicts: # src/main/java/fr/openmc/core/OMCPlugin.java # src/main/java/fr/openmc/core/features/milestones/MilestoneModel.java # src/main/java/fr/openmc/core/features/milestones/MilestoneType.java # src/main/java/fr/openmc/core/features/milestones/MilestoneUtils.java # src/main/java/fr/openmc/core/features/milestones/MilestonesManager.java # src/main/java/fr/openmc/core/features/milestones/menus/MainMilestonesMenu.java # src/main/java/fr/openmc/core/features/milestones/menus/MilestoneMenu.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/BreakAyweniteQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/CityCreateQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/CityLevelTwoQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/ClaimLetterQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/FinishQuestQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/HomeCreateQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/HomeUpgradeQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/OpenAdminShopMenuQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/OpenContestMenuQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/OpenQuestMenuQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/OpenSettingsMenuQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/SellBuyQuest.java # src/main/java/fr/openmc/core/features/milestones/tutorial/quests/SpareBankQuest.java # src/main/java/fr/openmc/core/features/quests/objects/Quest.java
Member
|
#1036 |
Contributor
Author
Normalement oui |
# Conflicts: # src/main/java/fr/openmc/core/OMCPlugin.java # src/main/java/fr/openmc/core/features/dream/DreamManager.java # src/main/java/fr/openmc/core/features/dream/listeners/dream/PlayerSleepListener.java # src/main/java/fr/openmc/core/features/dream/models/registry/items/DreamItem.java # src/main/java/fr/openmc/core/features/dream/registries/items/armors/dream/DreamBoots.java # src/main/java/fr/openmc/core/features/dream/registries/items/armors/dream/DreamChestplate.java # src/main/java/fr/openmc/core/features/dream/registries/items/armors/dream/DreamHelmet.java # src/main/java/fr/openmc/core/features/dream/registries/items/armors/dream/DreamLeggings.java
7 tasks
Contributor
Author
|
Je pense refaire une PR pour cette feature afin de la merge dans v2.5 et pas master, vous êtes d'accord ? |
Member
|
Non, inutile la branche va être delete bientôt |
Contributor
Author
|
A bon ? Pk ? |
Member
|
J'ai pas a répondre à cette question ici |
Member
|
Puis si tu fais ça tu te suicides tout seul (le nombre de conflit va te détruire |
Member
|
PR ne devra pas passer ces components en #1161. |
iambibi
requested changes
Mar 27, 2026
src/main/java/fr/openmc/core/features/quests/objects/Quest.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/openmc/core/features/quests/objects/Quest.java
Outdated
Show resolved
Hide resolved
| return; | ||
| } | ||
| if (clickInPlayerInv) return; | ||
| if (clickInPlayerInv) return; // Laisser |
Contributor
Author
There was a problem hiding this comment.
A vrai dire je ne sais plus, peut-être que j'avais prévu de faire un event DropInSingularity ?!
src/main/java/fr/openmc/core/features/dream/milestone/DreamMilestone.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/openmc/core/features/milestones/menus/MainMilestonesMenu.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/openmc/core/features/milestones/menus/MilestoneDialog.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/openmc/core/features/milestones/MilestoneQuest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
BON |
Contributor
Author
|
Reste plus qu'à tester |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR:
Ajout de la milestone des rêves (merci rylo pour la structure)
Étape nécessaire afin que la PR soit fini (si PR en draft)
Decrivez vos changements