Skip to content

🐛 fix: include edited comments in incremental timelines - #86

Merged
SigureMo merged 1 commit into
mainfrom
codex/edited-comments-timeline
Oct 4, 2026
Merged

SigureMo merged 1 commit into
mainfrom
codex/edited-comments-timeline

Conversation

@SigureMo

@SigureMo SigureMo commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Incremental timeline reads with --after skipped older comments edited after the previous read. Include the latest body edits in PR/issue comments, review bodies, and thread comments, while preserving original event timestamps, ordering, and IDs. Show edit timestamps separately and retain thread context; folded reviews keep an edit summary and an expansion command.

--before alone retains its existing event-time behavior. Issue follow-ups now scan older pages because an old comment can have a recent edit. The README and skill explain that the output contains current text and its latest edit time.

Validation:

  • All 169 tests passed, including edit-window boundaries, older issue pages, thread context, per-comment counts, and folded content.
  • Type, lint, format, and extension entrypoint checks passed.
  • Live ✨ feat: render native GitHub pull request stacks #82 reproduction: the comment created at 15:56:37 UTC and edited at 16:06:10 now appears in the 16:00–16:07 window, retaining event number 5 and its original timestamp.
This PR is co-authored with @codex (gpt-6 astra ultra)

Co-authored-by: Codex <noreply@openai.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Summary

  • Documented that comment-expand and review-expand retain GitHub’s latest edit timestamp, preserving edit provenance alongside expanded current content. README.mdL172-L176
  • Extended the mock GitHub responses with edited timestamps for both pull-request and issue comments. tests/test_cli.pyL341-L370
  • Added regression assertions verifying that PR and issue comment expansion renders the corresponding Edited metadata. tests/test_cli.pyL766-L772 tests/test_cli.pyL1886-L1891
  • Committed the changes as 6f51149 (test: cover edit metadata in comment expansion) and created the follow-up PR titled “test: preserve edit provenance in expanded comments.”

Testing

  • ✅ git diff --check
  • ✅ PYENV_VERSION=3.14.4 python -m compileall -q src tests
  • ✅ PYENV_VERSION=3.14.4 ruff check .
  • ✅ PYENV_VERSION=3.14.4 ruff format --check --diff .
  • ✅ prettier --check '**/*.md'
  • ⚠️ PYENV_VERSION=3.14.4 uv run pytest && PYENV_VERSION=3.14.4 uv run ty check --error-on-warning src/gh_llm tests && PYENV_VERSION=3.14.4 uv run ruff check . && PYENV_VERSION=3.14.4 uv run ruff format --check --diff . && prettier --check '**/*.md' && PYENV_VERSION=3.14.4 uv run pytest tests/test_extension_entrypoint.py (the environment could not download pluggy==1.5.0 because its network tunnel failed)

View task →

@SigureMo SigureMo changed the title fix: include edited comments in incremental timelines 🐛 fix: include edited comments in incremental timelines Oct 4, 2026
@SigureMo
SigureMo merged commit 02ed504 into main Oct 4, 2026
4 checks passed
@SigureMo
SigureMo deleted the codex/edited-comments-timeline branch October 4, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant