Skip to content

Fix severity level names support in CLI #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wetterkrank wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix severity level names support in CLI #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/erb_lint/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ def option_parser
end

opts.on("--fail-level SEVERITY", "Minimum severity for exit with error code") do |level|
parsed_severity = SEVERITY_CODE_TABLE[level.upcase.to_sym] || (SEVERITY_NAMES & [level.downcase]).first
parsed_severity = SEVERITY_CODE_TABLE[level.upcase.to_sym] || (SEVERITY_NAMES & [level.downcase.to_sym]).first

if parsed_severity.nil?
failure!("#{level}: not a valid failure level (#{SEVERITY_NAMES.join(", ")})")
Expand Down
2 changes: 1 addition & 1 deletion spec/erb_lint/cli_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ def run(processed_source)
end

context "when fail level is lower or equal than found errors" do
let(:args) { ["--lint-all", "--fail-level", "I", "--enable-linter", "linter_with_info_errors"] }
let(:args) { ["--lint-all", "--fail-level", "info", "--enable-linter", "linter_with_info_errors"] }

context "with the default glob" do
it "shows all error messages and line numbers" do
Expand Down