Log the error message of InvalidJwtTokenError#1721
Open
tomriley wants to merge 2 commits intoShopify:mainfrom
Open
Log the error message of InvalidJwtTokenError#1721tomriley wants to merge 2 commits intoShopify:mainfrom
tomriley wants to merge 2 commits intoShopify:mainfrom
Conversation
nelsonwittwer
approved these changes
Nov 8, 2023
Contributor
|
We can merge this in and ship it assuming you could help us get the CI to pass. Can I ask you to fix those errors on this branch? |
lizkenyon
added
the
Waiting for Response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Together with Shopify/shopify-api-ruby#1207 this patch prints the original decode error message coming from the jwt gem.
Reviewer's guide to testing
Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary