Integrate @ohm-js/wasm for browser-compatible parsing #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add foundational infrastructure for running browser-based e2e tests for the VS Code extension using @anthropic/vscode-test-web. Includes: - Test dependencies (mocha, chai, vscode-test-web) - Webpack configuration for test bundling - TypeScript and ESLint configuration for test files - Activation smoke test to verify extension loads in browser - Debug delay support for test development Co-Authored-By: Claude Opus 4.5 <[email protected]>
* Add watch mode for browser test development Introduces infrastructure for developing browser tests with live reload: - Add test:web:debug script that builds once and launches browser - Configure webpack to output debug bundle to separate file - Add dynamic test discovery to support single-file test runs This enables a faster development loop: edit tests, refresh browser, see results immediately without rebuilding. Co-Authored-By: Claude Opus 4.5 <[email protected]> * Add browser e2e test for Liquid object autocomplete Tests that Liquid object completions (e.g., 'product') appear when triggered inside {{ }} delimiters. This validates the end-to-end autocomplete flow in the browser test environment. Co-Authored-By: Claude Opus 4.5 <[email protected]> --------- Co-authored-by: Claude Opus 4.5 <[email protected]>
- Update root package.json to prettier ^3.0.0 - Add tsconfig paths mapping for Prettier 2 type compatibility - Add webpack alias for browser builds to use prettier2 - Reformat TypeScript files with Prettier 3 style changes Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
@ohm-js/wasm v0.6.17 FailedMatchResult returns generic "Match failed at pos N" messages instead of detailed syntax error information. getExpectedText() is not yet implemented in the WASM version. Co-Authored-By: Claude Opus 4.5 <[email protected]>
The @ohm-js/wasm package has TypeScript declaration inconsistencies (experimental package). skipLibCheck bypasses these errors without affecting type checking of our own code. Co-Authored-By: Claude Opus 4.5 <[email protected]>
charlespwd
force-pushed
the
cp-ohm-wasm-v2
branch
from
4062f5e to
e94e43a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates
@ohm-js/wasmto enable browser-compatible Liquid parsing in the VSCode extension, building on the browser test infrastructure from #1070.Changes
ohm-jswith@ohm-js/wasmv0.6.17createToAstpattern for grammar-to-AST compilationusingkeyword for proper resource managementifPresenthelper forOptNodehandlingskipLibCheck: trueto vscode-extension tsconfig for @ohm-js/wasm type compatibilityPrior Art
Testing
Browser integration tests pass with the wasm-based parser. The
usingkeyword ensures proper cleanup of wasm resources.🤖 Generated with Claude Code