Repository navigation
Dev workflow: one-command run, env examples, CI - #4
Open
shrish-browserstack wants to merge 2 commits into
Open
shrish-browserstack wants to merge 2 commits into
shrish-browserstack wants to merge 2 commits into
Conversation
- Remove gui.py and mode.pt (a 14.5 MB PyTorch model) — leftover artifacts from an unrelated YOLOv5 project, unused here. - Delete client/src/img/home.png (11 MB, 6000x4000) — not referenced anywhere in the client. - Remove the junk root package.json / package-lock.json (no name, no scripts, unrelated deps); the real apps live in client/ and server/. - Drop the server's placeholder dependencies http (0.0.1-security), path, and url. All three are Node built-ins that shadow these userland packages, and http@0.0.1-security is a security-hold stub that blocked npm install. Removes ~25 MB from the working tree. Verified: server npm install now succeeds and the client production build compiles. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Root package.json orchestrator: install:all, dev (client+server+socket via concurrently), build, lint - .env.example for server, client and socket; socket reads PORT/CLIENT_URL from env - GitHub Actions CI: install, lint, client build on Node 20 - .nvmrc, engines, .mailmap; plain Node .gitignore - Fix socket missing nodemon dep, move server nodemon to devDependencies, plain `node` start scripts - README rewritten around the three processes and correct .env locations; project-specific client README Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stacked on #3 (its commit shows in this diff until #3 merges). No behaviour changes to the app; this makes a clean clone runnable with one command and adds CI to keep it that way.
package.jsonwithinstall:all,dev,build,lintserver/.env.example,client/.env.example,socket/.env.example.envat the repo root whiledotenvloads fromserver/socket/index.jsreadsPORT/CLIENT_URLfrom env.github/workflows/ci.ymlnpm cia manifest that no longer exists and publish aprivate: trueweb app to a package registrysocket/package.json: addnodemondevDependency;server/package.json: movenodemonto devDependenciescd socket && npm ci && npm startfailed on a clean machine;startscripts now run plainnode,devscripts use nodemon.nvmrc,engines,.mailmapgit shortlog.gitignorerewrittenclient/README.mdreplacedproxycoupling, and the correct.envlocations; fixes broken ToC anchors and the branch-pinned self link@babel/plugin-proposal-private-property-in-objectdevDependencyVerification
npm run lintpasses:node --checkover server and socket, client ESLint exits 0 (64 pre-existing warnings, to be cleared in the frontend foundation PR).npm run buildcompiles the client.PORT=8999 CLIENT_URL=http://example.test node index.jslogs the values..envfiles ignored in all three apps,.env.exampletracked,client/buildignored.CI runs the client build with
CI=falseuntil the ESLint warnings are cleared, then that env line goes away.🤖 Generated with Claude Code