Skip to content

Conversation

@srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Apr 3, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Increased timeout values for data exporters to enhance system stability and reliability, reducing timeout-related errors during trace, metric, and log processing operations.

@coderabbitai
Copy link

coderabbitai bot commented Apr 3, 2025

Walkthrough

Updated OpenTelemetry exporter timeout configurations in the SignOz Helm values. Added 45-second timeouts to clickhousetraces and signozclickhousemetrics exporters, and increased existing timeouts from 10s to 45s for clickhouselogsexporter and metadataexporter.

Changes

Cohort / File(s) Summary
OpenTelemetry Exporter Timeouts
charts/signoz/values.yaml
Added timeout: 45s to clickhousetraces and signozclickhousemetrics exporters; updated clickhouselogsexporter and metadataexporter timeouts from 10s to 45s

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that the 45-second timeout value aligns with performance requirements and SLA targets
  • Confirm timeout values are appropriate for the expected query/export latency in production environments

Poem

🐰 Tick-tock, the clickers now wait,
Forty-five seconds feels just great,
No more rush, no more strain,
Exporters happy, traces refrain!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: increasing default timeouts for exporters in the configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch timeout-bump

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4fef57 and 363ba7e.

📒 Files selected for processing (1)
  • charts/signoz/values.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test-chart
🔇 Additional comments (1)
charts/signoz/values.yaml (1)

1903-1925: Consistent timeout increase across all ClickHouse exporters—LGTM.

All five exporters that connect to ClickHouse now have a uniform timeout: 45s setting, increasing from the previous 10s for some and adding it to others. The YAML structure and indentation are correct, and this aligns with the PR objective.

The 45-second timeout is a reasonable value for batched database operations; it provides sufficient time for ClickHouse to process large payloads while preventing indefinite hangs on network issues.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@srikanthccv srikanthccv marked this pull request as ready for review November 8, 2025 12:42
@srikanthccv srikanthccv requested a review from a team as a code owner November 8, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant