Skip to content

Conversation

@ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Nov 5, 2025

🔍 Related Issues

Part of #9323

📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)

image image

📋 Checklist

  • Dev Review
  • Test cases added (Unit/ Integration / E2E)
  • Manually tested the changes

@ahmadshaheer ahmadshaheer changed the title refactor: migrate external APIs -> endpoint metrics query range request to v5 refactor: migrate external APIs -> domain dropdown query range request to v5 Nov 6, 2025
eKuG
eKuG previously approved these changes Nov 7, 2025
@ahmadshaheer ahmadshaheer force-pushed the refactor/migrate-domain-dropdown-request-to-query_range-v5 branch from b6cfa05 to c6375b5 Compare November 10, 2025 13:05
@ahmadshaheer ahmadshaheer requested a review from eKuG November 11, 2025 13:01
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renders - when only url.full is presnt.

image

aks07
aks07 previously approved these changes Nov 12, 2025
@ahmadshaheer ahmadshaheer changed the base branch from main to refactor/external-apis-query_range-v5-migration-base-PR November 12, 2025 15:14
…ge-v5-migration-base-PR' into refactor/migrate-domain-dropdown-request-to-query_range-v5
@aks07 aks07 merged commit 8018f14 into refactor/external-apis-query_range-v5-migration-base-PR Nov 17, 2025
2 checks passed
@aks07 aks07 deleted the refactor/migrate-domain-dropdown-request-to-query_range-v5 branch November 17, 2025 06:08
nityanandagohain pushed a commit that referenced this pull request Nov 18, 2025
* fix: fix the issue of aggregation incorrectly falling back to count

* refactor: add support for v5 queries in endPointDetailsDataQueries of EndPointDetails

* chore: add common utility functions

* chore: add convertFiltersWithUrlHandling helper

* fix: remove the aggregateOperator fallback logic changes

* refactor: migrate external APIs -> endpoint metrics query range request to v5  (#9494)

* refactor: migrate endpoint metrics api to v5

* fix: overall improvements

* fix: add url checks

* chore: remove unnecessary tests

* chore: remove old test

* chore: aggregateAttribute to aggregations

* refactor: migrate status bar charts to v5 (#9548)

* refactor: migrate status bar charts to v5

* chore: add tests

* chore: remove unnecessary tests

* chore: aggregateAttribute to aggregations

* fix: fix the failing test

* refactor: migrate external APIs -> domain metrics query range request to v5 (#9484)

* refactor: migrate domain metrics query_range to v5

* fix: overall bugfixes

* chore: fix the failing tests

* refactor: migrate dependent services to query range v5 (#9549)

* refactor: migrate dependent services to query_range v5

* chore: remove unnecessary tests

* chore: aggregateAttribute to aggregations

* refactor: migrate rate over time and latency charts query to v5 (#9544)

* fix: fix the issue of aggregation incorrectly falling back to count

* refactor: migrate rate over time and latency charts query to v5

* chore: write tests for rate over time and latency over time charts

* chore: overall improvements to the test

* fix: add url checks

* chore: remove the unnecessary tests

* chore: aggregateAttribute to aggregations

* fix: fix the failing tests

* chore: remove unnecessary test

* refactor: migrate "all endpoints" query range request to v5 (#9557)

* feat: add support for hiding columns in GridTableComponent

* refactor: migrate all endpoints section query payload to v5

* chore: aggregateAttribute to aggregations

* test: add V5 migration tests for all endpoints tab

* fix: add http.url exists or url.full exists to ensure we don't get null data

* fix: fallback to url.full while displaying endpoint value

* fix: update renderColumnCell type to accept variable arguments

* fix: remove type casting for renderColumnCell in getAllEndpointsWidgetData

* refactor: migrate external APIs -> domain dropdown query range request to v5 (#9495)

* refactor: migrate domain dropdown request to query_range v5

* fix: add utility to add http.url or url.full to the filter expression

* chore: aggregateAttribute to aggregations

* fix: add http.url exists or url.full exists to ensure we don't get null data

* fix: fallback to url.full if http.url doesn't exist

* fix: fix the failing test

* test: add V5 migration tests for endpoint dropdown query

* fix: fix the failing ts check

* fix: fix the failing tests

* fix: fix the failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants