[test] extent tests, coverage and harden responses#52
Open
herostrat wants to merge 1 commit intoSignalK:masterfrom
Open
[test] extent tests, coverage and harden responses#52herostrat wants to merge 1 commit intoSignalK:masterfrom
herostrat wants to merge 1 commit intoSignalK:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of new features I experiment with I decided to upgrade the tests
I think I found also found and fixed some inconsistencies:
Filesystem tile serving now validates the tile format and ensures the target path is a readable, regular file before serving. If not, it returns 404.
MBTiles serving also validates the tile format and returns 404 for unsupported formats.
The empty-chart scenario no longer yields false positives: resources may be missing, but any tile request returns 404.
The API serves individual tiles, not containers. When a tile is missing, unreadable, out of range, or in an unsupported format, the client should receive a clear “not found” response. This prevents accidental 200s for invalid paths or files and avoids leaking unintended filesystem content.
So I added integration tests for unsupported formats, unreadable tiles, invalid parameters, out-of-range zoom, and out-of-range tile coordinates.
Note: the new tests were primarily created with the help of AI.