build(deps-dev): bump sharp from 0.34.5 to 0.35.0#95
Conversation
Bumps [sharp](https://github.com/lovell/sharp) from 0.34.5 to 0.35.0. - [Release notes](https://github.com/lovell/sharp/releases) - [Commits](lovell/sharp@v0.34.5...v0.35.0) --- updated-dependencies: - dependency-name: sharp dependency-version: 0.35.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
PR author is in the excluded authors list. |
|
🤖 Review skipped: reviews for bot-created pull requests are not allowed on free accounts. Upgrade to a paid plan to enable bot reviews. |
| "postcss-cli": "^11.0.1", | ||
| "postcss-loader": "^7.3.3", | ||
| "sharp": "^0.34.3", | ||
| "sharp": "^0.35.0", |
There was a problem hiding this comment.
🟡 Project still advertises support for a Node version the new image library no longer supports
The image-processing dependency is upgraded (sharp to ^0.35.0 at package.json:80), but this version drops Node.js 18 and requires Node.js >= 20.9.0, while the project still declares support for Node.js 18, so anyone installing on Node 18/19 gets a broken tool.
Impact: Contributors on Node 18/19 (the officially advertised minimum) will hit install/runtime failures when running the image optimization build step.
Engine declaration mismatch between package.json engines and sharp requirement
sharp 0.35.0's first release note is "Breaking: Drop support for Node.js 18, now requires Node.js >= 20.9.0." However package.json:92-95 still declares "node": ">=18.0.0", and CLAUDE.md repeatedly states Node: >=18.0.0. sharp is used by scripts/optimize-images.js:1 (invoked via the optimize-images npm script). A user honoring the declared engine range on Node 18.x/19.x would pass the engines check but fail to load sharp. The declared engine range and docs should be updated to >=20.9.0 to match the new dependency. Note the actual CI (.github/workflows/* use Node 20) and Netlify (NODE_VERSION = "20.12.2") environments satisfy the requirement, limiting real impact to local/other environments.
Prompt for agents
sharp 0.35.0 requires Node.js >= 20.9.0 (it drops Node 18 support). After bumping sharp to ^0.35.0 in package.json, the engines.node field (currently ">=18.0.0" around package.json:93) is now inconsistent with the dependency's actual requirement, and CLAUDE.md also states Node: >=18.0.0 in multiple places. Update the engines.node constraint to ">=20.9.0" (or at least >=20.0.0 aligned with the deployment NODE_VERSION 20.12.2) and update the corresponding Node version references in CLAUDE.md so the declared minimum matches what the toolchain actually supports.
Was this helpful? React with 👍 or 👎 to provide feedback.
Bumps sharp from 0.34.5 to 0.35.0.
Release notes
Sourced from sharp's releases.
... (truncated)
Commits
2ed5af4Release v0.35.04475cf1Tests: update locator hash for sharp-libvips v1.3.0deb22ddUpgrade to sharp-libvips v1.3.007f1be9Prerelease v0.35.0-rc.8df1109bPrerelease v0.35.0-rc.7aca49b3Upgrade to libvips v8.18.3e9e86f5Type-check density option before range validation (#4536)2f0bcf0Docs: update supported image formats98e03b8Revert "Guard heif bitdepth property for prebuilt binaries"e4ea2f3CI: Ignore package minimum age in smoke testsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by cubic
Upgrade dev dependency
sharpto 0.35.0 to pick up the latest libvips and platform binaries, including new WASM packages.Dependencies
sharpto0.35.0; updates transitive@img/*binaries (libvips1.3.0) andsemver.Migration
sharpno longer runs an install script; if you previously built it from source, trigger builds manually as needed.Written for commit cfd4413. Summary will update on new commits.