[PERFORMANCE] [MER-5838] Scope Insights page attempts to delivery - #6770
Merged
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 36041959 | Triggered | Company Email Password | 950700a | priv/scenarios/insights_page_detail_perf.scenario.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Contributor
Contributor
AI Review — performanceNo issues found |
Contributor
AI Review — securityNo issues found |
Contributor
AI Review — elixirNo issues found |
darrensiegel
approved these changes
Aug 17, 2026
nicocirio
marked this pull request as ready for review
August 18, 2026 11:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
Summary
Scopes
Oli.Publishing.DeliveryResolver.students_with_attempts_for_page/3to thedelivery project (
project_id = -1).Previously, the query included
resource_summaryrows from unrelated authoringprojects that happened to reference the same resource. That could include students
without delivery attempts for the selected page and caused the page-detail query to
scan a large portion of
resource_summary.The new scope returns only delivery analytics data and lets PostgreSQL use the
existing
resource_summary_scopesindex.Performance Impact
Validation used a dedicated local database with 10,000,351
resource_summaryrows: 500 enrolled students, 350 delivery attempts on the selected scored page,
and 10,000 unrelated project scopes per student across scored and practice pages.
Both query versions ran against this exact same dataset.
Each query was measured five times with
EXPLAIN ANALYZE; the values below aremedian execution times.
Oli.Publishing.DeliveryResolver.students_with_attempts_for_page/3The original plan used a parallel sequential scan over approximately 5 million
page-related
resource_summaryrows, including unrelated project scopes. Theupdated plan uses an index-only scan through
resource_summary_scopesand readsonly the relevant delivery scope.
The temporary seed and benchmark harness is preserved for reference in
benchmark v1.
Validation
considered.
mix test test/oli/publishing/delivery_resolver_students_with_attempts_test.exs.filters with the same seeded database: approximately five seconds on
master,effectively instantaneous on this branch.
Video Evidence
Before (
master)before.mov
After (this branch)
after.mov