Skip to content

Use smaller language pickers with two-letter labels - #171

Merged
haltakov merged 3 commits into
mainfrom
codex/compact-language-picker
Nov 14, 2026
Merged

haltakov merged 3 commits into
mainfrom
codex/compact-language-picker

Conversation

@haltakov

@haltakov haltakov commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

The website language picker now shows short labels such as 🇧🇷 PT instead of PT-BR. Chinese uses 🇨🇳 简体 and 🇹🇼 繁體 so the two scripts remain distinguishable. Other supported languages use their uppercase two-letter language code.

The control fits its selected label (about 49px for EN in the actual site previews, down from 76px), with a 12px wire globe, close chevron and 1.75rem minimum height. Browsers without content-sizing use a compact 4rem fallback. The native select menu receives compact styling where supported; other browsers keep their standard menu, and forced-color mode restores the system control. Full language names remain in accessible labels/tooltips. Canonical locale values such as pt-BR, zh-Hans and zh-Hant, locale detection, saved preferences and URL routing are unchanged.

Validation: Common package build/declarations, 2 existing i18n tests, TypeScript, lint and formatting passed; actual modern-gallery initialization and locale switching passed. Across the coordinated changes, all 150 labels match the expected short forms; browser fixtures using the actual picker code/styles pass 40 LTR/RTL mobile/desktop checks, with visible focus and no horizontal overflow. The six actual photo-gallery initializers also preserve short labels after switching language and leave captions unchanged.

Standalone gallery users receive this through the normal coordinated common/theme/CLI npm release after merge, using the existing tag-triggered workflow. This PR does not publish packages.

Additional validation: all 15 labels fit in each control; keyboard opening and selection, high-contrast fallback, and the 40 LTR/RTL mobile/desktop layouts pass. All six Astro footers compile. Actual SimplePost and SimplePhoto site screenshots verify both closed and open states.

This is a separate presentation-only follow-up to the localization work. No merge or deployment is performed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T15:10:50.713516Z 72755c4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@haltakov
haltakov merged commit c49619d into main Nov 14, 2026
1 check passed
@haltakov
haltakov deleted the codex/compact-language-picker branch November 14, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant