Repository navigation
Use smaller language pickers with two-letter labels - #171
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The website language picker now shows short labels such as 🇧🇷 PT instead of PT-BR. Chinese uses 🇨🇳 简体 and 🇹🇼 繁體 so the two scripts remain distinguishable. Other supported languages use their uppercase two-letter language code.
The control fits its selected label (about 49px for EN in the actual site previews, down from 76px), with a 12px wire globe, close chevron and 1.75rem minimum height. Browsers without content-sizing use a compact 4rem fallback. The native select menu receives compact styling where supported; other browsers keep their standard menu, and forced-color mode restores the system control. Full language names remain in accessible labels/tooltips. Canonical locale values such as
pt-BR,zh-Hansandzh-Hant, locale detection, saved preferences and URL routing are unchanged.Validation: Common package build/declarations, 2 existing i18n tests, TypeScript, lint and formatting passed; actual modern-gallery initialization and locale switching passed. Across the coordinated changes, all 150 labels match the expected short forms; browser fixtures using the actual picker code/styles pass 40 LTR/RTL mobile/desktop checks, with visible focus and no horizontal overflow. The six actual photo-gallery initializers also preserve short labels after switching language and leave captions unchanged.
Standalone gallery users receive this through the normal coordinated common/theme/CLI npm release after merge, using the existing tag-triggered workflow. This PR does not publish packages.
Additional validation: all 15 labels fit in each control; keyboard opening and selection, high-contrast fallback, and the 40 LTR/RTL mobile/desktop layouts pass. All six Astro footers compile. Actual SimplePost and SimplePhoto site screenshots verify both closed and open states.
This is a separate presentation-only follow-up to the localization work. No merge or deployment is performed.