Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
Newer JEI versions moved the internal configuration logic to a seperate library, MezzConfig. This caused related changes in the JEI source.
The Proposal
Update JEI to the latest beta and make the same renames to the JEI Bridge as JEI did.
Possible Side Effects
This introduces a hard dependency on beta versions of JEI. Players not using these betas will not be able to update JEI.
Alternatives
A separate bridge could be made for newer JEI versions, or the bridge could be disabled when running on too new versions of JEI. I'm of the opinion the betas are functional enough, and my current pack requires the latest JEI beta to load.