Skip to content

Conversation

@MelanX
Copy link

@MelanX MelanX commented Mar 24, 2025

In some cases, a connection may not have any channel. In this case, ChannelAttributes.getOrCreateCommonChannels shouldn't be called because it creates a NullPointerException. If the channel is null, it should just not continue with collecting channels and initializing it for the addon.

Maybe, we should also not check isConnected but instead isConnecting since isConnected also checks for Channel#isOpen and isConnecting only checks if channel is null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants