[WOODPECKER-4303] Migrate from pnpm 10 to pnpm 11#4657
Open
Viktor Yang (viktor-yang) wants to merge 4 commits into
Open
[WOODPECKER-4303] Migrate from pnpm 10 to pnpm 11#4657Viktor Yang (viktor-yang) wants to merge 4 commits into
Viktor Yang (viktor-yang) wants to merge 4 commits into
Conversation
b115e18 to
5cb82ab
Compare
|
Visit https://backpack.github.io/storybook-prs/4657 to see this build running in a browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Migrates the repo from pnpm 10 to pnpm 11, following the same pattern used in
Skyscanner/global-components#3412.Changes
package.json—packageManager→pnpm@11.0.8,engines.pnpm→>=11.0.8; addedpeerDependencyRulesto document pre-existing peer dep mismatches (eslint 9 + react 18) that the frozen lockfile was silently bypassing; removedonlyBuiltDependencies/ignoredBuiltDependencies(migrated topnpm-workspace.yaml)libs/backpack-storybook-host/package.json— syncedpackageManager+engines.pnpm.npmrc— removed the 5 settings now living inpnpm-workspace.yaml; onlyregistry=remainspnpm-workspace.yaml— added migrated settings (strictPeerDependencies,engineStrict,publicHoistPattern,linkWorkspacePackages) andallowBuilds(replacesonlyBuiltDependencies/ignoredBuiltDependencies)pnpm-lock.yaml— regenerated with pnpm 11.0.8.github/workflows/*.yml(5 files) — pinned all 14pnpm/action-setup@v4.1.0occurrences to@fc06bc12... # v5.0.0(v6 has a bootstrap auth bug).github/dependabot.yml— addedpnpm/action-setup >=6.0.0ignore rule so Dependabot doesn't bump back to v6Why
peerDependencyRules?The lockfile was last regenerated during the pnpm 9→10 migration. Since then, CI only ran
--frozen-lockfilewhich skips peer dep evaluation. Regenerating the lockfile with pnpm 11 surfaces two pre-existing mismatches:@typescript-eslintv7 declareseslint@^8peer dep — we're on eslint 9 (needs typescript-eslint (@typescript-eslint) v8 to fix properly, separate concern)bpk-react-utils/bpk-storybook-utilsdeclarereact@^17peer dep — we're on react 18Adding
peerDependencyRules.allowedVersionsis the correct pnpm way to document known acceptable mismatches without looseningstrictPeerDependencies.Remember to include the following changes:
[Clover-123][BpkButton] Updating the colourREADME.md(If you have created a new component) — N/AREADME.md— N/A