chore: V43 major regression test-3#4660
Draft
Richard-Shen (RichardSyq) wants to merge 3 commits into
Draft
Conversation
The prop relied on scrollIntoView from a useEffect on mount, which silently no-ops when the carousel is rendered inside a parent that hasn't laid out yet (e.g. AnimateHeight at display: none). The sole intended consumer (ExpandedPricingOption in web-platform) hit exactly this and has since switched to a manual ref-based scroll triggered after its parent's animation completes (IRN-6568). No other consumers exist, so the prop is dead weight with a misleading API. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Visit https://backpack.github.io/storybook-prs/4660 to see this build running in a browser. |
Contributor
Dev Release PublishedVersion: Install with: You can also use the dev tag to install the latest dev release: Published from commit d034c1a by Richard-Shen (@RichardSyq). |
Richard-Shen (RichardSyq)
temporarily deployed
to
Publishing
GitHub Actions
Inactive
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V43 Major Regression Branch
This is a combined draft PR aggregating all approved
major-labelled PRs for the upcoming V43 major release.Merged PRs
Notes
origin/mainatac522e5ef