[CLOV-1600][BpkScrollableCalendar] Bump react-window to v2#4668
Closed
Vincent Liu (xiaogliu) wants to merge 1 commit into
Closed
[CLOV-1600][BpkScrollableCalendar] Bump react-window to v2#4668Vincent Liu (xiaogliu) wants to merge 1 commit into
Vincent Liu (xiaogliu) wants to merge 1 commit into
Conversation
12 tasks
Contributor
Author
|
There are no security vulnerabilities in @react-window and @types/react-window version 1.x, and their current features meet our requirements. However, version 2.x comes with API changes and will alter the behavior of bpk-component-scrollable-calendar. Taking the development effort, risks and practical benefits into consideration, I believe there is no need to upgrade @react-window and @types/react-window to version 2.0 for now so close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLOV-1600. Replaces the previous draft migration in #4477 with a version rebased onto the current
mainrepository structure.Migrates the only
react-windowconsumer,BpkScrollableCalendarGridList, from v1 to v2:ListreplacesVariableSizeList; rendering now usesrowComponent+rowPropsrowCount/rowHeightreplace v1itemCount/itemSizeuseListRef+scrollToRowreplaces the old initial pixel offset pathreact-virtualized-auto-sizeris removed because v2 has built-in sizing@types/react-windowis removed because v2 ships its own typesResizeObserveris mocked in the affected jsdom testsreact-window/@types/react-windowValidation
npx eslint packages/backpack-web/src/bpk-component-scrollable-calendar/src/BpkScrollableCalendarGridList.tsx packages/backpack-web/src/bpk-component-scrollable-calendar/src/BpkScrollableCalendarGridList-test.tsx packages/backpack-web/src/bpk-component-scrollable-calendar/src/BpkScrollableCalendar-test.tsx packages/backpack-web/src/bpk-component-scrollable-calendar/src/accessibility-test.tsx --ext .ts,.tsxTZ=Etc/UTC npx jest packages/backpack-web/src/bpk-component-scrollable-calendar/src/BpkScrollableCalendarGridList-test.tsx packages/backpack-web/src/bpk-component-scrollable-calendar/src/BpkScrollableCalendar-test.tsx packages/backpack-web/src/bpk-component-scrollable-calendar/src/accessibility-test.tsxnpm run check-bpk-dependenciesnpm run check-react-versionsnpm run lintexits 0; existing repo warnings still printnpm run jestpasses: 390 suites passed, 1 skipped; 2666 tests passed, 3 skipped; 825 snapshots passednpm run typecheckcurrently fails on existing story declaration issues forbpk-component-price/bpk-theming; no scrollable-calendar or react-window errors were reported before those failuresNotes
This supersedes #4477. #3997 is already closed.