Skip to content

Remove self-cast button conflict warning #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Snakybo wants to merge 1 commit into
base: clicked-2
Choose a base branch
from
Open

Remove self-cast button conflict warning #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ This document contains a temporary changelog to keep track of changes made in ve
### Removed

* Remove the ability tooltips module, as Midnight has severely handicapped the feature
* Remove the self-cast button conflict warning
20 changes: 1 addition & 19 deletions Clicked/Core/Clicked.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,6 @@ local function HandleChatCommand(input)
Addon:StatusOutput_Open()
elseif (args[1] == "viz" or args[1] == "visualizer") then
Addon.KeyVisualizer:Open()
elseif args[1] == "ignore-self-cast-warning" then
Addon.db.profile.options.ignoreSelfCastWarning = not Addon.db.profile.options.ignoreSelfCastWarning

if Addon.db.profile.options.ignoreSelfCastWarning then
Clicked2:LogInfo(Addon.L["Disabled self-cast warning, type this command again to re-enable it."])
else
Clicked2:LogInfo(Addon.L["Enabled self-cast warning, type this command again to disable it."])
end
end
end
end
Expand Down Expand Up @@ -377,20 +369,10 @@ end
function Clicked2:OnEnable()
--@debug@
local projectUrl = "https://www.curseforge.com/wow/addons/clicked"
Clicked2:LogWarning("You are using a development version, download the latest release from {url}", projectUrl)
self:LogWarning("You are using a development version, download the latest release from {url}", projectUrl)
--@end-debug@

UpdateEventHooks(self, self.RegisterEvent)

-- self-cast warning
if not Addon.db.profile.options.ignoreSelfCastWarning and Addon.EXPANSION >= Addon.Expansion.DF then
local selfCastModifier = GetModifiedClick("SELFCAST")

if selfCastModifier ~= "NONE" then
local message = Addon.L["The behavior of the self-cast modifier has changed in Dragonflight, bindings using the '{key}' key modifier may not work correctly. It is recommended to disable it by setting it to 'NONE' in the options menu. You can disable this warning by typing: {command}"]
Clicked2:LogWarning(message, selfCastModifier, "/clicked ignore-self-cast-warning")
end
end
end

function Clicked2:OnDisable()
Expand Down
3 changes: 0 additions & 3 deletions Clicked/Locales/enUS.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,6 @@ L["Change scope"] = true
L["Profile"] = true
L["Imported Clicked profile from %s"] = true
L["Global"] = true
L["The behavior of the self-cast modifier has changed in Dragonflight, bindings using the '{key}' key modifier may not work correctly. It is recommended to disable it by setting it to 'NONE' in the options menu. You can disable this warning by typing: {command}"] = true
L["Disabled self-cast warning, type this command again to re-enable it."] = true
L["Enabled self-cast warning, type this command again to disable it."] = true
L["X"] = true
L["Not"] = true
L["Select talents"] = true
Expand Down