Skip to content

Use BqUtils for sharded read schema validation#716

Merged
kmontemayor2-sc merged 3 commits into
mainfrom
kmonte/sharded-read-bq-utils
Jul 22, 2026
Merged

Use BqUtils for sharded read schema validation#716
kmontemayor2-sc merged 3 commits into
mainfrom
kmonte/sharded-read-bq-utils

Conversation

@kmontemayor2-sc

Copy link
Copy Markdown
Collaborator

What

  • Uses BqUtils.fetch_bq_table_schema for sharded-read shard-key validation.
  • Removes the standalone BigQuery client and table-reference construction from sharded_read.py.
  • Adds focused tests for valid shard keys, missing columns, and missing tables.

Why

Schema lookup is already owned by BqUtils. Reusing that API removes duplicate BigQuery client construction while preserving the existing validation and error behavior.

Testing

  • sharded_read_test.py: 3 tests passed.
  • Scoped ty checks passed for all changed Python files.
  • Ruff check and formatting passed for all changed Python files.

@mkolodner-sc mkolodner-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kmontemayor2-sc
kmontemayor2-sc marked this pull request as ready for review July 22, 2026 14:01
@kmontemayor2-sc
kmontemayor2-sc added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit 638ba91 Jul 22, 2026
7 checks passed
@kmontemayor2-sc
kmontemayor2-sc deleted the kmonte/sharded-read-bq-utils branch July 22, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants