Add card component #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefirex
reviewed
Mar 8, 2020
bluefirex
reviewed
Mar 8, 2020
Co-Authored-By: Benjamin Schmidt <[email protected]>
fredericobormann
requested changes
Apr 11, 2020
Contributor
fredericobormann
left a comment
fredericobormann
left a comment
There was a problem hiding this comment.
Looks very good, one little change is needed to make the cardTitle work :)
| --> | ||
| <template> | ||
| <div class="apos-card"> | ||
| <h3 class="apos-card-title">{{ this.CardTitle }}</h3> |
Contributor
There was a problem hiding this comment.
Suggested change
| <h3 class="apos-card-title">{{ this.CardTitle }}</h3> | |
| <h3 class="apos-card-title">{{ this.cardTitle }}</h3> |
cardTitle is spelled lowercase in props
bluefirex
reviewed
Apr 11, 2020
| props: { | ||
| CardTitle: String | ||
| cardTitle: String |
Contributor
There was a problem hiding this comment.
Vorschlag: Nur title, dass es der Kartentitel ist, wird durch die Komponente selbst offensichtlich.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a card component.