SONARPHP-1537 S1068 should not raise on private static singleton #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
ZiadMarey
changed the title
ZiadMarey
requested review from
malte-skoruppa-sonarsource
and removed request for
malte-skoruppa-sonarsource
ZiadMarey
force-pushed
the
zm/SONARPHP-1537
branch
from
27155ab to
c040107
Compare
felix-pauck-sonarsource
approved these changes
Jan 2, 2026
felix-pauck-sonarsource
left a comment
felix-pauck-sonarsource
left a comment
There was a problem hiding this comment.
LGTM! 👍
Only minor suggestions 🙂. No second review needed, but if you want, I can have a second look if/after you made changes. 😉
php-frontend/src/main/java/org/sonar/php/tree/symbols/SymbolVisitor.java
Show resolved
Hide resolved
php-frontend/src/main/java/org/sonar/php/tree/symbols/SymbolVisitor.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.